1.6.4 partial support #170
Merged
+1,850
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoogieMonster1O1
requested changes
May 5, 2024
...pi-v1/common/src/testmod/java/net/legacyfabric/fabric/test/command/ModMetadataCommandV1.java
Show resolved
Hide resolved
...bric-command-api-v2/1.6.4/src/main/java/net/legacyfabric/fabric/api/command/v2/Selector.java
Outdated
Show resolved
Hide resolved
...2/1.6.4/src/main/java/net/legacyfabric/fabric/api/command/v2/lib/sponge/CommandCallable.java
Outdated
Show resolved
Hide resolved
...-v2/1.6.4/src/main/java/net/legacyfabric/fabric/api/command/v2/lib/sponge/CommandResult.java
Outdated
Show resolved
Hide resolved
|
as for keybindings I think we should extend the keybinding screen. best if it goes in another PR 🙌 |
thecatcore
added
enhancement
# Conflicts: # gradle.properties
...sions-api-v1/1.6.4/src/main/java/net/legacyfabric/fabric/impl/permission/PermissionImpl.java
Outdated
Show resolved
Hide resolved
...sions-api-v1/1.8.9/src/main/java/net/legacyfabric/fabric/impl/permission/PermissionImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #169.
Modules not ported:
Keybinds screen in pre-1.7 isn't made for dynamic amount of entries, should we provide our own screen for it?
Also it seems like Gson global parser doesn't always work as intended, so I switched to gson's JsonParser instead and it works in every case and versions so far.
A test mod was added for command api v1.
Gamerule module hasn't been tested for now.